linux-kernel - Re: linux-next: Tree for Oct 31 (ehci, dbgp)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 01 Nov 2012 19:46:52 +0000
From:	"Jan Beulich" <jbeulich@...e.com>
To:	<rdunlap@...radead.org>, <stern@...land.harvard.edu>
Cc:	<sfr@...b.auug.org.au>, <linux-kernel@...r.kernel.org>,
	<linux-next@...r.kernel.org>, <linux-usb@...r.kernel.org>
Subject: Re: linux-next: Tree for Oct 31 (ehci, dbgp)

>>> Alan Stern <stern@...land.harvard.edu> 11/01/12 4:28 PM >>>
>On Wed, 31 Oct 2012, Randy Dunlap wrote:
>> on x86_64:
>> 
>> drivers/built-in.o: In function `ehci_reset':
>> host.c:(.text+0x542a7e): undefined reference to `dbgp_reset_prep'
>> host.c:(.text+0x542b75): undefined reference to `dbgp_external_startup'
>> drivers/built-in.o: In function `ehci_bus_resume':
>> host.c:(.text+0x544705): undefined reference to `dbgp_reset_prep'
>> host.c:(.text+0x544731): undefined reference to `dbgp_external_startup'
>
>We all forgot about the chipidea driver.  It includes code from 

I didn't even know of this.

>ehci-hcd in a rather unorthodox manner (see 
>drivers/usb/chipidea/host.c).
>
>Evidently we need to change your new test in
>drivers/usb/early/ehci-dbgp.c to:
>
>#if IS_ENABLED(CONFIG_USB_HCD_EHCI) || defined(CONFIG_USB_CHIPIDEA_HOST)
>
>Upcoming changes to ehci-hcd will make this unnecessary in 3.8, but for 
>now we need it.

Which tells me that the CONFIG_USB_SUPPORT version would have been
the better one  (and I would favor that over the ugly variant you suggest
above).

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/