linux-kernel - Re: [PATCH] kbuild: add symbol prefix arg to kallsyms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121101202902.GA6439@merkur.ravnborg.org>
Date:	Thu, 1 Nov 2012 21:29:02 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	James Hogan <james@...anarts.com>
Cc:	Mike Frysinger <vapier@...too.org>, Michal Marek <mmarek@...e.cz>,
	uclinux-dist-devel@...ckfin.uclinux.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: add symbol prefix arg to kallsyms

On Thu, Sep 06, 2012 at 10:11:25PM +0100, James Hogan wrote:
> Commit 1f2bfbd00e466ff3489b2ca5cc75b1cccd14c123 ("kbuild: link of
> vmlinux moved to a script") introduced in v3.5-rc1 broke kallsyms on
> architectures which have symbol prefixes.
> 
> The --symbol-prefix argument used to be added to the KALLSYMS command
> line from the architecture Makefile, however this isn't picked up by the
> new scripts/link-vmlinux.sh. This resulted in symbols like
> kallsyms_addresses being added which weren't correctly overriding the
> weak symbols such as _kallsyms_addresses. These could then trigger
> BUG_ONs in kallsyms code.
> 
> This is fixed by removing the KALLSYMS addition from the architecture
> Makefile, and using CONFIG_SYMBOL_PREFIX in the link-vmlinux.sh script
> to determine whether to add the --symbol-prefix argument.
> 
> Signed-off-by: James Hogan <james.hogan@...tec.com>
Acked-by: Sam Ravnborg <sam@...nborg.org>

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/