linux-kernel - RE: [PATCH] mtip32xx: remove unused variables from mtip32xx.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A360F954C61C69449463B060666371121CDEC867@CDCEXMBX02.tw.trendnet.org>
Date:	Thu, 1 Nov 2012 05:14:33 +0000
From:	"yongjun_wei@...ndmicro.com.cn" <yongjun_wei@...ndmicro.com.cn>
To:	Wei Yongjun <weiyj.lk@...il.com>,
	"axboe@...nel.dk" <axboe@...nel.dk>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mtip32xx: remove unused variables from mtip32xx.c

Hi all

Sorry, please ignore this mail, this mail just be resend by my mistake.

Regards,
Yongjun Wei

-----Original Message-----
From: Wei Yongjun [mailto:weiyj.lk@...il.com] 
Sent: 2012年11月1日 13:09
To: axboe@...nel.dk
Cc: Yongjun Wei (RD-CN); linux-kernel@...r.kernel.org
Subject: [PATCH] mtip32xx: remove unused variables from mtip32xx.c

From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

The variables fis, reply are initialized but never used otherwise, so remove the unused variables.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
---
 drivers/block/mtip32xx/mtip32xx.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index adc6f36..d1e0273 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -555,7 +555,6 @@ static void print_tags(struct driver_data *dd,  static void mtip_timeout_function(unsigned long int data)  {
 	struct mtip_port *port = (struct mtip_port *) data;
-	struct host_to_dev_fis *fis;
 	struct mtip_cmd *command;
 	int tag, cmdto_cnt = 0;
 	unsigned int bit, group;
@@ -587,7 +586,6 @@ static void mtip_timeout_function(unsigned long int data)
 			bit = tag & 0x1F;
 
 			command = &port->commands[tag];
-			fis = (struct host_to_dev_fis *) command->command;
 
 			set_bit(tag, tagaccum);
 			cmdto_cnt++;
@@ -1142,10 +1140,8 @@ static void mtip_issue_non_ncq_command(struct mtip_port *port, int tag)  static bool mtip_pause_ncq(struct mtip_port *port,
 				struct host_to_dev_fis *fis)
 {
-	struct host_to_dev_fis *reply;
 	unsigned long task_file_data;
 
-	reply = port->rxfis + RX_FIS_D2H_REG;
 	task_file_data = readl(port->mmio+PORT_TFDATA);
 
 	if (fis->command == ATA_CMD_SEC_ERASE_UNIT)



<table class="TM_EMAIL_NOTICE"><tr><td><pre>
TREND MICRO EMAIL NOTICE
The information contained in this email and any attachments is confidential 
and may be subject to copyright or other intellectual property protection. 
If you are not the intended recipient, you are not authorized to use or 
disclose this information, and we request that you notify us by reply mail or
telephone and delete the original message from your mail system.
</pre></td></tr></table>