linux-kernel - Re: [PATCH 00/25] perf test: Add perf_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121101232055.GA1690@krava.redhat.com>
Date:	Fri, 2 Nov 2012 00:20:56 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 00/25] perf test: Add perf_event_attr tests

On Thu, Nov 01, 2012 at 05:38:01PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Oct 30, 2012 at 11:01:41PM +0100, Jiri Olsa escreveu:
> > hi,
> > this code tests the link between perf stat/record command line
> > options and final perf_event_attr struct values. Also it tests
> > the group fd linkage.
> > 
> > Plus moving test related objects under 'test' directory.
> 
> Ok, so I applied this to my local perf/core branch with a few changes,
> namely to move 24/25 to after 5/25 so that I could do, for each
> subsequent tests:
> 
> $ make -j8 -C tools/perf/ O=/home/acme/git/build/perf install
> $ perf test -v perf_event_attr
> 
> And see if each one passed.
> 
> So at the end I changed
> /home/acme/libexec/perf-core/tests/attr/base-record flipping
> "watermark=0" to "watermark=1" and got:
> 
> [root@...dy ~]# perf test perf_event_attr
> 13: struct perf_event_attr setup                           :FAILED '/home/acme/libexec/perf-core/tests/attr/test-record-count' - match failure
>  FAILED!
> [root@...dy ~]#
> 
> But I wanted it to show _what_ didn't match, so I tried:
> 
> [root@...dy ~]# perf test -v perf_event_attr
> 13: struct perf_event_attr setup                           :
> --- start ---
> running '/home/acme/libexec/perf-core/tests/attr/test-record-count'
> FAILED '/home/acme/libexec/perf-core/tests/attr/test-record-count' - match failure
> ---- end ----
> struct perf_event_attr setup: FAILED!
> [root@...dy ~]#

yep, you'd need to run:
  python ./tests/attr.py -d ./tests/attr/ -p ./perf -t test-record-count -vvv

to see what really did not match

'perf test attr' takes just single -v option into account

could be changed ;)

> 
> Also is there a strict need for setting PERF_TEST_ATTR? I thought that if it
> found the /home/acme/libexec/perf-core/tests/attr/ dirs it would test it, but
> haven't dug deep, care to ellaborate here?

PERF_TEST_ATTR instructs perf to store each event details into PERF_TEST_ATTR directory

and python script is running 'PERF_TEST_ATTR=/tmp/temp perf ...' to get events


> 
> Ah, I just pushed perf/core with this patchset, thanks!

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/