linux-kernel - regulator: tps51632: Seems current code doesn't properly support dvfs_step

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1351752521.4588.2.camel@phoenix>
Date:	Thu, 01 Nov 2012 14:48:41 +0800
From:	Axel Lin <axel.lin@...ics.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org
Subject: regulator: tps51632: Seems current code doesn't properly support
 dvfs_step_20mV case

Hi Laxman,

While reading the tps51632 driver, I found there is a dvfs_step_20mV setting
in platform data. But seems current code doesn't properly handle the case when
dvfs_step_20mV is true.

I guess if pdata->dvfs_step_20mV is true, we need:

tps->desc.uV_step = TPS51632_VOLATGE_STEP_20mV;
Fix TPS51632_VOLT_VSEL macro to support dvfs_step_20mV case.
Also I'm wondering if either TPS51632_MAX_VSEL/TPS51632_MAX_VOLATGE or
desc.n_voltages needs change for dvfs_step_20mV case.

Oh, I don't have the datasheet, so my understanding might be wrong.

Regards,
Axel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/