linux-kernel - Re: [PATCH] IRQ CORE: irq_work_queue function return value not used.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Nov 2012 09:43:34 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	anish kumar <anish198519851985@...il.com>
Cc:	linux-kernel@...r.kernel.org, peterz@...radead.org,
	akpm@...ux-foundation.org, paul.gortmaker@...driver.com,
	tglx@...utronix.de, mingo@...nel.org, fweisbec@...il.com
Subject: Re: [PATCH] IRQ CORE: irq_work_queue function return value not used.

On Fri, 2012-11-02 at 22:24 +0900, anish kumar wrote:
> From: anish kumar <anish198519851985@...il.com>
> 
> As no one is using the return value of irq_work_queue function
> it is better to just make it void.

Acked-by: Steven Rostedt <rostedt@...dmis.org>

Peter, like to take this patch? Or is there a reason you have for
irq_work_queue() returning a value?

-- Steve

> Signed-off-by: anish kumar <anish198519851985@...il.com>
> ---
>  kernel/irq_work.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> index 1588e3b..a85c4b3 100644
> --- a/kernel/irq_work.c
> +++ b/kernel/irq_work.c
> @@ -79,17 +79,17 @@ static void __irq_work_queue(struct irq_work *work)
>   *
>   * Can be re-enqueued while the callback is still in progress.
>   */
> -bool irq_work_queue(struct irq_work *work)
> +void irq_work_queue(struct irq_work *work)
>  {
>  	if (!irq_work_claim(work)) {
>  		/*
>  		 * Already enqueued, can't do!
>  		 */
> -		return false;
> +		return;
>  	}
>  
>  	__irq_work_queue(work);
> -	return true;
> +	return;
>  }
>  EXPORT_SYMBOL_GPL(irq_work_queue);
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/