linux-kernel - Re: [PATCH] [PATCH] x86: Don't clobber top of pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1351865489.4004.137.camel@gandalf.local.home>
Date:	Fri, 02 Nov 2012 10:11:29 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jan Beulich <JBeulich@...e.com>
Cc:	sqazi@...gle.com, peterz@...radead.org, tglx@...utronix.de,
	torvalds@...ux-foundation.org, hpa@...ux.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [PATCH] x86: Don't clobber top of pt_regs in nested NMI

On Fri, 2012-11-02 at 14:09 +0000, Jan Beulich wrote:

> >>  	subq $(5*8), %rsp
> >> +	CFI_ADJUST_CFA_OFFSET 5*8
> >>  
> >>  	CFI_DEF_CFA_OFFSET SS+8-RIP
> >>  end_repeat_nmi:
> >> 
> > 
> > Is that second one even needed? Or will the CFI_DEF_CFA_OFFSET SS+8-RIP
> > fix it?
> 
> Yes it will (as long as no intervening instructions get added; that's
> to say that I'd recommend removing the blank line to make clear
> that instruction and annotation belong together).

OK, will do.

Thanks!

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/