linux-kernel - Re: linux-next: build warning after merge of the usb tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1211021014180.1356-100000@iolanthe.rowland.org>
Date:	Fri, 2 Nov 2012 10:18:57 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Felipe Balbi <balbi@...com>
cc:	Stephen Rothwell <sfr@...b.auug.org.au>, Greg KH <greg@...ah.com>,
	<linux-next@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Subject: Re: linux-next: build warning after merge of the usb tree

On Fri, 2 Nov 2012, Felipe Balbi wrote:

> Hi,
> 
> On Fri, Nov 02, 2012 at 03:08:28PM +1100, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_init_driver' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_resume' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_suspend' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > WARNING: drivers/usb/host/ehci-hcd: 'ehci_setup' exported twice. Previous export was in drivers/usb/chipidea/ci_hdrc.ko
> > 
> > Introduced by commit 3e0232039967 ("USB: EHCI: prepare to make ehci-hcd a
> > library module").
> 
> Alex, why on earth is chipidea exporting symbols it doesn't own ?

That's at least partly my fault.  ehci-hcd.c now exports four symbols 
that it didn't before.  Since the ChipIdea driver does

	#include "../host/ehci-hcd.c"

it now exports them too, unintentionally.  A quick band-aid fix would 
be to protect those functions with

	#ifndef CHIPIDEA_EHCI

but the real fix is the patch I posted yesterday -- assuming it works 
right.  If we don't hear back from Alex soon, I will post the band-aid 
fix as a temporary stop-gap.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/