linux-kernel - Re: [PATCH 3/5] staging: zcache2+ramster: enable zcache2 to be built/loaded as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121102183950.GD30100@konrad-lan.dumpdata.com>
Date:	Fri, 2 Nov 2012 14:39:50 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Dan Magenheimer <dan.magenheimer@...cle.com>
Cc:	devel@...uxdriverproject.org, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, linux-mm@...ck.org, ngupta@...are.org,
	sjenning@...ux.vnet.ibm.com, minchan@...nel.org,
	fschmaus@...il.com, andor.damm@...glemail.com,
	ilendir@...glemail.com, akpm@...ux-foundation.org, mgorman@...e.de
Subject: Re: [PATCH 3/5] staging: zcache2+ramster: enable zcache2 to be
 built/loaded as a module

On Wed, Oct 31, 2012 at 08:07:52AM -0700, Dan Magenheimer wrote:
> Allow zcache2 to be built/loaded as a module.  Note runtime dependency
> disallows loading if cleancache/frontswap lazy initialization patches
> are not present.  Zsmalloc support has not yet been merged into zcache2
> but, once merged, could now easily be selected via a module_param.
> 
> If built-in (not built as a module), the original mechanism of enabling via
> a kernel boot parameter is retained, but this should be considered deprecated.
> 
> Note that module unload is explicitly not yet supported.

I had an issue putting it on v3.7-rc3 with the Kconfig. Not sure why
as it looks exactly the same.

The patch looks good, however..

> @@ -1812,9 +1846,28 @@ static int __init zcache_init(void)
>  	}
>  	if (ramster_enabled)
>  		ramster_init(!disable_cleancache, !disable_frontswap,
> -				frontswap_has_exclusive_gets);
> +				frontswap_has_exclusive_gets,
> +				!disable_frontswap_selfshrink);
>  out:
>  	return ret;
>  }

.. ramster_init change is in the next patch. So it looks like the
patch order is a bit mismatched.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/