lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 3 Nov 2012 11:58:33 +0100 From: Julia Lawall <Julia.Lawall@...6.fr> To: Joern Engel <joern@...fs.org> Cc: kernel-janitors@...r.kernel.org, Prasad Joshi <prasadjoshi.linux@...il.com>, logfs@...fs.org, linux-kernel@...r.kernel.org Subject: [PATCH 12/16] fs/logfs/gc.c: use WARN From: Julia Lawall <Julia.Lawall@...6.fr> Use WARN rather than printk followed by WARN_ON(1), for conciseness. A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression list es; @@ -printk( +WARN(1, es); -WARN_ON(1); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> --- fs/logfs/gc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/logfs/gc.c b/fs/logfs/gc.c index d4efb06..62dee03 100644 --- a/fs/logfs/gc.c +++ b/fs/logfs/gc.c @@ -55,9 +55,8 @@ static u8 root_distance(struct super_block *sb, gc_level_t __gc_level) /* inode file data or indirect blocks */ return super->s_ifile_levels - (gc_level - 6); default: - printk(KERN_ERR"LOGFS: segment of unknown level %x found\n", + WARN(1, KERN_ERR "LOGFS: segment of unknown level %x found\n", gc_level); - WARN_ON(1); return super->s_ifile_levels + super->s_iblock_levels; } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists