lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 03 Nov 2012 13:11:36 +0100 From: walter harms <wharms@....de> To: Julia Lawall <Julia.Lawall@...6.fr> CC: Arnd Bergmann <arnd@...db.de>, kernel-janitors@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jason Wessel <jason.wessel@...driver.com>, kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH 11/16] drivers/misc/kgdbts.c: use WARN Am 03.11.2012 11:58, schrieb Julia Lawall: > From: Julia Lawall <Julia.Lawall@...6.fr> > > Use WARN rather than printk followed by WARN_ON(1), for conciseness. > > A simplified version of the semantic patch that makes this transformation > is as follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression list es; > @@ > > -printk( > +WARN(1, > es); > -WARN_ON(1); > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> > > --- > drivers/misc/kgdbts.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c > index 3aa9a96..8b367db 100644 > --- a/drivers/misc/kgdbts.c > +++ b/drivers/misc/kgdbts.c > @@ -114,9 +114,8 @@ > touch_nmi_watchdog(); \ > } while (0) > #define eprintk(a...) do { \ > - printk(KERN_ERR a); \ > - WARN_ON(1); \ > - } while (0) > + WARN(1, KERN_ERR a); \ > + } while (0) > #define MAX_CONFIG_LEN 40 > A macro calling a macro ? Is it possible to replace eprintk() ? re, wh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists