lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 03 Nov 2012 17:35:33 +0100 From: Bart Van Assche <bvanassche@....org> To: Jeff Moyer <jmoyer@...hat.com> CC: linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org, "James E.J. Bottomley" <JBottomley@...allels.com> Subject: Re: [patch,v2 01/10] scsi: add scsi_host_alloc_node On 11/02/12 22:45, Jeff Moyer wrote: > diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c > index 593085a..7d7ad8b 100644 > --- a/drivers/scsi/hosts.c > +++ b/drivers/scsi/hosts.c > @@ -336,16 +336,25 @@ static struct device_type scsi_host_type = { > **/ > struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize) > { > + return scsi_host_alloc_node(sht, privsize, -1); Using NUMA_NO_NODE here might improve readability. > diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h > index 4908480..a1b5c8e 100644 > --- a/include/scsi/scsi_host.h > +++ b/include/scsi/scsi_host.h > @@ -733,6 +733,12 @@ struct Scsi_Host { > struct device *dma_dev; > > /* > + * Numa node this device is closest to, used for allocating > + * data structures locally. > + */ > + int numa_node; Have you considered using #ifdef CONFIG_NUMA / #endif here ? I've noticed that all other numa_node members in structures under include/ have this. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists