linux-kernel - Re: [PATCH] atp: remove set_rx_mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121103.154356.693234817224225347.davem@davemloft.net>
Date:	Sat, 03 Nov 2012 15:43:56 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	pebolle@...cali.nl
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atp: remove set_rx_mode_8012()

From: Paul Bolle <pebolle@...cali.nl>
Date: Sat, 03 Nov 2012 10:53:15 +0100

> Building atp.o triggers this GCC warning:
>     drivers/net/ethernet/realtek/atp.c: In function ‘set_rx_mode’:
>     drivers/net/ethernet/realtek/atp.c:871:26: warning: ‘mc_filter[0]’ may be used uninitialized in this function [-Wuninitialized]
> 
> GCC is correct. In promiscuous mode 'mc_filter' will be used
> uninitialized in set_rx_mode_8012(), which is apparently inlined into
> set_rx_mode().
> 
> But it turns out set_rx_mode_8012() will never be called, since
> net_local.chip_type will always be RTL8002. So we can just remove
> set_rx_mode_8012() and do some related cleanups.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>

Applied.