| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1351974625-10282-3-git-send-email-Julia.Lawall@lip6.fr> Date: Sat, 3 Nov 2012 21:30:19 +0100 From: Julia Lawall <Julia.Lawall@...6.fr> To: Krishna C Gudipati <kgudipat@...cade.com> Cc: kernel-janitors@...r.kernel.org, "James E.J. Bottomley" <JBottomley@...allels.com>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 2/8] drivers/scsi/bfa/bfa_svc.c: drop if around WARN_ON From: Julia Lawall <Julia.Lawall@...6.fr> Just use WARN_ON rather than an if containing only WARN_ON(1). A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e; @@ - if (e) WARN_ON(1); + WARN_ON(e); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> --- drivers/scsi/bfa/bfa_svc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/bfa/bfa_svc.c b/drivers/scsi/bfa/bfa_svc.c index 299c1c8..765b8d0 100644 --- a/drivers/scsi/bfa/bfa_svc.c +++ b/drivers/scsi/bfa/bfa_svc.c @@ -626,8 +626,7 @@ bfa_fcxp_init_reqrsp(struct bfa_fcxp_s *fcxp, /* * alloc required sgpgs */ - if (n_sgles > BFI_SGE_INLINE) - WARN_ON(1); + WARN_ON(n_sgles > BFI_SGE_INLINE); } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists