linux-kernel - Re: [PATCH] x86: remove dummy long from EFI stub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1352052841.14888.190.camel@mfleming-mobl1.ger.corp.intel.com>
Date:	Sun, 04 Nov 2012 18:14:01 +0000
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Cesar Eduardo Barros <cesarb@...arb.net>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Jordan Justen <jordan.l.justen@...el.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] x86: remove dummy long from EFI stub

On Sat, 2012-10-27 at 20:34 -0200, Cesar Eduardo Barros wrote:
> Commit 2e064b1 (x86, efi: Fix issue of overlapping .reloc section for
> EFI_STUB) removed a dummy reloc added by commit 291f363 (x86, efi: EFI
> boot stub support), but forgot to remove the dummy long used by that
> reloc.
> 
> Cc: Jordan Justen <jordan.l.justen@...el.com>
> Cc: Matt Fleming <matt.fleming@...el.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Signed-off-by: Cesar Eduardo Barros <cesarb@...arb.net>
> ---
>  arch/x86/boot/header.S | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index 2a01744..8c132a6 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -476,6 +476,3 @@ die:
>  setup_corrupt:
>  	.byte	7
>  	.string	"No setup signature found...\n"
> -
> -	.data
> -dummy:	.long	0

This change seems fine to me. Jordan, would you mind ACKing this if
you're OK with it?

-- 
Matt Fleming, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/