linux-kernel - Re: [PATCH] samsung-laptop: Disable if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121104193741.7b4ca37b@pyramind.ukuu.org.uk>
Date:	Sun, 4 Nov 2012 19:37:41 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Corentin Chary <corentincj@...aif.net>
Cc:	Matt Fleming <matt@...sole-pimps.org>,
	Matthew Garrett <mjg@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-efi@...r.kernel.org,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	Alessandro Crismani <alessandro.crismani@...il.com>,
	Mikhail Bakhterev <mike.bakhterev@...il.com>,
	Patrick H <kernel@...storm.net>,
	Matt Fleming <matt.fleming@...el.com>,
	"H. Peter Anvin" <hpa@...or.com>, stable@...r.kernel.org
Subject: Re: [PATCH] samsung-laptop: Disable if CONFIG_EFI=y

> Acked-by: Corentin Chary <corentin.chary@...il.com>

This is totally bogus and prevents users build a kernel which can work in
either mode. As such its a regression.

Do the detection check at runtime. If it was booted via EFI then don't
grovel in places you shouldn't. Indeed its possible EFI should reserve
those memory regions ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/