linux-kernel - Re: [PATCH v2 2/3] fat: notify when discard is not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k3u0micj.fsf@devron.myhome.or.jp>
Date:	Mon, 05 Nov 2012 19:53:16 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Amit Sahrawat <amit.sahrawat83@...il.com>
Subject: Re: [PATCH v2 2/3] fat: notify when discard is not supported

Namjae Jeon <linkinjeon@...il.com> writes:

> FAT also notify warning message about discard support
> as ext4(http://patchwork.ozlabs.org/patch/192668/)

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

> Signed-off-by: Namjae Jeon <linkinjeon@...il.com>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@...il.com>
> ---
>  fs/fat/inode.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 8d79657..3b48bab 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -26,6 +26,7 @@
>  #include <linux/writeback.h>
>  #include <linux/log2.h>
>  #include <linux/hash.h>
> +#include <linux/blkdev.h>
>  #include <asm/unaligned.h>
>  #include "fat.h"
>  
> @@ -1446,6 +1447,14 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
>  		goto out_fail;
>  	}
>  
> +	if (sbi->options.discard) {
> +		struct request_queue *q = bdev_get_queue(sb->s_bdev);
> +		if (!blk_queue_discard(q))
> +			fat_msg(sb, KERN_WARNING,
> +					"mounting with \"discard\" option, but "
> +					"the device does not support discard");
> +	}
> +
>  	return 0;
>  
>  out_invalid:

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/