linux-kernel - Re: [PATCH] samsung-laptop: Disable if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1352117601.14888.278.camel@mfleming-mobl1.ger.corp.intel.com>
Date:	Mon, 05 Nov 2012 12:13:21 +0000
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Corentin Chary <corentincj@...aif.net>
Cc:	Matthew Garrett <mjg@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-efi@...r.kernel.org,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	Alessandro Crismani <alessandro.crismani@...il.com>,
	Mikhail Bakhterev <mike.bakhterev@...il.com>,
	Patrick H <kernel@...storm.net>,
	"H. Peter Anvin" <hpa@...or.com>, stable@...r.kernel.org
Subject: Re: [PATCH] samsung-laptop: Disable if CONFIG_EFI=y

On Sun, 2012-11-04 at 17:44 +0000, Corentin Chary wrote:
> On Sun, Nov 4, 2012 at 5:35 PM, Matt Fleming <matt@...sole-pimps.org> wrote:
> > From: Matt Fleming <matt.fleming@...el.com>
> >
> > We've started getting reports of users seeing Machine Check Exceptions
> > when booting their Samsung laptops in UEFI mode,
> >
> >      https://bugzilla.kernel.org/show_bug.cgi?id=47121
> >
> > This module seems to be the culprit as it's grovelling around in the
> > 0xf0000 region which has no mapping in either the e820 or EFI memory
> > maps on the affected machines.
> >
> > Reported-by: Alessandro Crismani <alessandro.crismani@...il.com>
> > Reported-by: Mikhail Bakhterev <mike.bakhterev@...il.com>
> > Tested-by: Patrick H <kernel@...storm.net>
> > Cc: H. Peter Anvin <hpa@...or.com>
> > Cc: Matthew Garrett <mjg@...hat.com>
> > Cc: Corentin Chary <corentincj@...aif.net>
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Matt Fleming <matt.fleming@...el.com>
> > ---
> >  drivers/platform/x86/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > index c86bae8..0fe5200 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -717,7 +717,7 @@ config XO15_EBOOK
> >
> >  config SAMSUNG_LAPTOP
> >         tristate "Samsung Laptop driver"
> > -       depends on X86
> > +       depends on X86 && !EFI
> >         depends on RFKILL || RFKILL = n
> >         depends on BACKLIGHT_CLASS_DEVICE
> >         select LEDS_CLASS
> > --
> > 1.7.11.7
> >
> 
> Acked-by: Corentin Chary <corentin.chary@...il.com>
> 
> Matthew could you merge this in your tree ? Thanks.
> 
> Matt, any idea if SABI doesn't exist on these machines, or is just
> mapped somewhere else ?
> By any luck, could Samsung tell you how to safely detect SABI aware machines ?

I don't know whether or not SABI exists on these machines and I don't
have one of them to try and figure that out, sorry.

-- 
Matt Fleming, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/