linux-kernel - Re: [PATCH 1/5] fat: remove parent_logstart check in fat_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 05 Nov 2012 21:27:02 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Ravishankar N <ravi.n1@...sung.com>,
	Amit Sahrawat <a.sahrawat@...sung.com>
Subject: Re: [PATCH 1/5] fat: remove parent_logstart check in fat_get_parent

Namjae Jeon <linkinjeon@...il.com> writes:

> +		blknr = fat_clus_to_blknr(sbi, parent_logstart);
> +		parent_bh = sb_bread(sb, blknr);
> +		if (!parent_bh) {
> +			fat_msg(sb, KERN_ERR,
> +				"NFS:unable to read cluster of parent directory");
> +			goto out;
>  		}
> +		de = (struct msdos_dir_entry *) parent_bh->b_data;
> +		clus_to_match = fat_get_start(sbi, &de[0]);
> +		search_clus = fat_get_start(sbi, &de[1]);
> +		if (!search_clus)
> +			search_clus = sbi->root_cluster;
> +		brelse(parent_bh);
> +		do {
> +			parent_inode =  fat_traverse_cluster(sb,
> +					search_clus, clus_to_match);
> +			if (IS_ERR(parent_inode) || parent_inode)
> +				break;
> +			search_clus = fat_read_next_clus(sb,
> +							search_clus);
> +			if (search_clus < 0)
> +				break;
> +		} while (search_clus != FAT_ENT_EOF);
>  	}
>  out:
>  	brelse(dotdot_bh);

I started to understand what is doing this with cleanup. It is really
strange and duplicates many codes with bugs.

So, please replace whole FAT nfs patches in -mm to review whole at next
patchset. And sorry, but please think whole more carefully.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/