[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87k3u0ydry.fsf@rustcorp.com.au>
Date: Mon, 05 Nov 2012 13:08:57 +1030
From: Rusty Russell <rusty@...tcorp.com.au>
To: Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org
Cc: Lee Jones <lee.jones@...aro.org>,
virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH 6/9] virtio_mmio: Cast &resources[1].start to
‘unsigned int *’ to rid compiler
warning
Lee Jones <lee.jones@...aro.org> writes:
> drivers/virtio/virtio_mmio.c: In function ‘vm_cmdline_set’:
> drivers/virtio/virtio_mmio.c:535:4: warning: format ‘%u’ expects argument of type ‘unsigned int *’, but argument 4 has type ‘resource_size_t *’ [-Wformat]
>
> Cc: Rusty Russell <rusty@...tcorp.com.au>
> Cc: virtualization@...ts.linux-foundation.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
> drivers/virtio/virtio_mmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 6b1b7e1..077e9ca 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -531,7 +531,7 @@ static int vm_cmdline_set(const char *device,
> resources[0].end = memparse(device, &str) - 1;
>
> processed = sscanf(str, "@%lli:%u%n:%d%n",
> - &base, &resources[1].start, &consumed,
> + &base, (unsigned int *)&resources[1].start, &consumed,
> &vm_cmdline_id, &consumed);
This suppresses a valid warning, leaving our code no less wrong than
before. But now it's silently wrong!
Do you want to try again?
Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists