[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20121105143541.GD5220@gmail.com>
Date: Mon, 5 Nov 2012 15:35:41 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Pawel Moll <pawel.moll@....com>
Cc: Rusty Russell <rusty@...tcorp.com.au>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"virtualization@...ts.linux-foundation.org"
<virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter
On Mon, 05 Nov 2012, Pawel Moll wrote:
> On Mon, 2012-11-05 at 13:44 +0000, Lee Jones wrote:
> > On Mon, 05 Nov 2012, Pawel Moll wrote:
> >
> > > On 64-bit machines resource_size_t is a 64-bit value, while
> > > sscanf() format for this argument was defined as "%u". Fixed
> > > by using an intermediate local value of a known length.
> > >
> > > Also added cleaned up the resource creation and adde extra
> > > comments to make the parameters parsing easier to follow.
> > >
> > > Reported-by: Lee Jones <lee.jones@...aro.org>
> > > Signed-off-by: Pawel Moll <pawel.moll@....com>
> > > ---
> > > drivers/virtio/virtio_mmio.c | 26 ++++++++++++++++++--------
> > > 1 file changed, 18 insertions(+), 8 deletions(-)
> >
> > Resorted to poaching now have we Pawel? ;)
>
> Sure thing - the poached eggs are my firm favourite :-P ;-)
>
> But seriously speaking - it's an old patch (all the comments and
> resources creation, the IRQ stuff is a new thing :-), but never had
> enough motivation to push it out...
I believe you, many would not. ;)
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists