linux-kernel - Re: [PATCH] w1-gpio: Simplify & get rid of defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121105154745.GB12922@ioremap.net>
Date:	Mon, 5 Nov 2012 19:47:45 +0400
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Pantelis Antoniou <panto@...oniou-consulting.com>
Cc:	linux-kernel@...r.kernel.org,
	Koen Kooi <koen@...inion.thruhere.net>,
	Matt Porter <mporter@...com>, Russ Dill <Russ.Dill@...com>,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH] w1-gpio: Simplify & get rid of defines

Hi

On Wed, Oct 31, 2012 at 05:57:44PM +0200, Pantelis Antoniou (panto@...oniou-consulting.com) wrote:
> There's no reason to have the OF defines; it complicates the driver.
> There's also no need for the funky platform_driver_probe.
> 
> Add a few warnings in case there's a failure; helps us find out
> what went wrong.
> 
> Signed-off-by: Pantelis Antoniou <panto@...oniou-consulting.com>

Looks good to me, but I'm hardly an expert in omap platform.
Feel free to add my ack, but please submit this patch through
appropriate tree.
Thank you.

Acked-by: Evgeniy Polyakov <zbr@...emap.net>

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/