linux-kernel - Re: [PATCH v3 5/5] iio: adc: add viperboard adc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5097E201.7040008@metafoo.de>
Date:	Mon, 05 Nov 2012 16:57:53 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Lars Poeschel <larsi@....tu-dresden.de>
CC:	linus.walleij@...aro.org, poeschel@...onage.de,
	sameo@...ux.intel.com, linux-kernel@...r.kernel.org,
	jic23@....ac.uk, khali@...ux-fr.org, ben-linux@...ff.org,
	w.sang@...gutronix.de, grant.likely@...retlab.ca,
	linux-iio@...r.kernel.org
Subject: Re: [PATCH v3 5/5] iio: adc: add viperboard adc driver

On 11/05/2012 03:48 PM, Lars Poeschel wrote:
> From: Lars Poeschel <poeschel@...onage.de>
> 
> This adds the mfd cell to use the adc part of the Nano River Technologies
> viperboard.
> 
> Signed-off-by: Lars Poeschel <poeschel@...onage.de>

Looks good to me.

Reviewed-by: Lars-Peter Clausen <lars@...afoo.de>

If you happen to resend the series there is one tiny bit that could be
changed, but no need to resend the series just for this.

> ---
>  drivers/iio/adc/Kconfig          |    7 ++
>  drivers/iio/adc/Makefile         |    1 +
>  drivers/iio/adc/viperboard_adc.c |  181 ++++++++++++++++++++++++++++++++++++++
>  drivers/mfd/viperboard.c         |    3 +
>  include/linux/mfd/viperboard.h   |    1 +
>  5 files changed, 193 insertions(+)
>  create mode 100644 drivers/iio/adc/viperboard_adc.c
> 

> +
> +static int __devinit vprbrd_adc_probe(struct platform_device *pdev)
> +{
> +	struct vprbrd *vb = dev_get_drvdata(pdev->dev.parent);
> +	struct vprbrd_adc *adc;
> +	struct iio_dev *indio_dev;
> +	int ret;
> +
> +	/* registering iio */
> +	indio_dev = iio_device_alloc(sizeof(struct vprbrd_adc));

sizeof(*adc)

> +	if (!indio_dev) {
> +		dev_err(&pdev->dev, "failed allocating iio device\n");
> +		return -ENOMEM;
> +	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/