linux-kernel - Re: [PATCH 2/2] regulator: tps80031: add regulator driver for tps80031

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121106081647.GC3283@opensource.wolfsonmicro.com>
Date:	Tue, 6 Nov 2012 09:16:48 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"lrg@...com" <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] regulator: tps80031: add regulator driver for
 tps80031

On Mon, Nov 05, 2012 at 05:30:02PM +0530, Laxman Dewangan wrote:
> On Monday 05 November 2012 04:12 PM, Mark Brown wrote:

> >Should we be using different versions of the ops depending on the device
> >flags rather than having these switches?  It seems like we can't change
> >at runtime and it would make the code a lot simpler.

> I have single dcdc ops for all DCDC VIO, SMPS1 to 3.
> There is different configuration bit for selecting any DCDC to
> normal, extended or offset. As this ops are share, I can not change
> the callbacks.

You can change your code so that it changes the ops it registers
depending on the configuration.

> >Why the + 1 (and - 1 in the get()).  I'd expect we can just use the
> >register value directly as a selector.

> The device sets vout = 0 if vsel = 0 and then equation talk about
> the Vmin + vsel * step.
> I exported the Vout minimum as Vmin for sel = 0 and hence this is there.

> I will export this in true equation in my next patch.

You can just have list_voltage() return 0 for this voltage - it's OK to
have missing selector values.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)