linux-kernel - Re: [PATCH v2] pinctrl: samsung: Add ifdef CONFIG_OF_GPIO guard for gc->of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZXm=QdDUZ3Mdt0uZ7Y8i24AgMRzgBLsiWbJTCPH1nFUw@mail.gmail.com>
Date:	Tue, 6 Nov 2012 09:57:40 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Thomas Abraham <thomas.abraham@...aro.org>
Cc:	Axel Lin <axel.lin@...ics.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Tomasz Figa <t.figa@...sung.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl: samsung: Add ifdef CONFIG_OF_GPIO guard for gc->of_node

On Tue, Nov 6, 2012 at 6:03 AM, Thomas Abraham
<thomas.abraham@...aro.org> wrote:
> On 5 November 2012 21:14, Axel Lin <axel.lin@...ics.com> wrote:

>> +#if defined(CONFIG_OF_GPIO)
>>                 gc->of_node = bank->of_node;
>> +#endif
>
> The samsung pinctrl driver supports only device tree enabled
> platforms. So instead of adding the above #if, would it not be better
> to add 'select OF_GPIO' for Samsung pinctrl driver in
> drivers/pinctrl/Kconfig. ?

Or edit the Samsung driver to depend on OF_GPIO, this is probably
better.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/