linux-kernel - Re: [PATCH] regulator: core: avoid memory access after freeing it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121106113138.GB10080@opensource.wolfsonmicro.com>
Date:	Tue, 6 Nov 2012 12:31:38 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	Laxman Dewangan <ldewangan@...dia.com>, lrg@...com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: core: avoid memory access after freeing it

On Tue, Nov 06, 2012 at 11:12:56AM +0000, Charles Keepax wrote:

> Here would it not make sense to go slightly further and basically
> revert my original change. This feels sensible as it keeps it at
> only one location where the mutex is unlocked and removes the
> second exit point I added. This would effectively make the code
> look like:

Given the bug that was reported with your original change and the lack
of any fix I'm actually just going to discard it anyway, just didn't get
around to it yet.

A single exit path would be simpler and hence better.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)