linux-kernel - Re: [PATCH 5/7] mfd: max8925: support dt for regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <509A2185.4030706@marvell.com>
Date:	Wed, 07 Nov 2012 16:53:25 +0800
From:	Qing Xu <qingx@...vell.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	"lrg@...com" <lrg@...com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"haojian.zhuang@...il.com" <haojian.zhuang@...il.com>,
	Chao Xie <cxie4@...vell.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>
Subject: Re: [PATCH 5/7] mfd: max8925: support dt for regulator

On 11/06/2012 05:01 PM, Mark Brown wrote:
> On Tue, Nov 06, 2012 at 03:44:52PM +0800, Qing Xu wrote:
>> From: Qing Xu <qingx@...vell.com>
>>
>> Signed-off-by: Qing Xu <qingx@...vell.com>
>> ---
>>   drivers/regulator/max8925-regulator.c |   35 ++++++++++++++++++++++++++++++++-
>>   1 files changed, 34 insertions(+), 1 deletions(-)
> There is no binding document here, documentation is required for all new
> bindings.
>
>> +	nproot = of_find_node_by_name(nproot, "regulators");
>> +	if (!nproot) {
>> +		dev_err(&pdev->dev, "failed to find regulators node\n");
>> +		return -ENODEV;
>> +	}
>> +	for_each_child_of_node(nproot, np) {
>> +		if (!of_node_cmp(np->name, info->desc.name)) {
>> +			config->init_data =
>> +				of_get_regulator_init_data(&pdev->dev, np);
>> +			config->of_node = np;
>> +			break;
>> +		}
>> +	}
> You appear to be open coding something like the standard helpers in
> of_regulator.h, you should use those helpers.
Mark, thanks for your so quick response! I updated the patch in v2, 
please help me review it again.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/