linux-kernel - Re: [PATCH V2 3/3] checkpatch: Emit an warning when floating point values are used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121107094006.GE3066@dm>
Date:	Wed, 7 Nov 2012 09:40:06 +0000
From:	Andy Whitcroft <apw@...onical.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Joe Perches <joe@...ches.com>, Adil Mujeeb <mujeeb.adil@...il.com>,
	Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 3/3] checkpatch: Emit an warning when floating point
 values are used

On Tue, Nov 06, 2012 at 03:36:25PM -0800, Andrew Morton wrote:
> On Thu,  1 Nov 2012 00:12:18 -0700
> Joe Perches <joe@...ches.com> wrote:
> 
> > Linux kernel doesn't like floating point, say so.
> > 
> > ...
> >
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -2332,6 +2332,13 @@ sub process {
> >  			     "do not add new typedefs\n" . $herecurr);
> >  		}
> >  
> > +# check for floating point constants
> > +
> > +		if ($line =~ /\b$Float\b/) {
> > +			WARN("KERNEL_FLOAT",
> > +			     "Floating point is not supported in linux kernel source\n" . $herecurr);
> > +		}
> > +
> >  # * goes on variable not on type
> >  		# (char*[ const])
> >  		while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) {
> 
> The earlier review comments were not addressed.
> 
> In particular, I don't see a problem with people doing
> 
> 	int foo = 1.1 * 2.2;

I thought there was also now a way to enable floats in kernel space and
some use thereof.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/