linux-kernel - Re: [PATCH v4 5/7] mfd: max8925: support dt for regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121107142007.GB20844@opensource.wolfsonmicro.com>
Date:	Wed, 7 Nov 2012 15:20:08 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Qing Xu <qingx@...vell.com>
Cc:	lrg@...com, sameo@...ux.intel.com, grant.likely@...retlab.ca,
	rob.herring@...xeda.com, haojian.zhuang@...il.com,
	cxie4@...vell.com, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH v4 5/7] mfd: max8925: support dt for regulator

On Wed, Nov 07, 2012 at 06:09:53PM +0800, Qing Xu wrote:
> From: Qing Xu <qingx@...vell.com>
> 
> Signed-off-by: Qing Xu <qingx@...vell.com>

Applied, thanks.

> +max8925 regulator device register is still handled by mfd_add_devices, not by
> +of_xxx, so, it is not necessary to add compatible name. Also, those reg
> +offset and id info is stored in mfd_cell(see max8925-core.c), as a result
> +there is not private properties in dts.

> +node's name should match with the definition in max8925_regulator_matches
> +(see max8925-regulator.c)

Please submit a followup which removes all the Linux-specific references
and just enumerates the supported regulators.  Please do also use a
subject line appropriate for the subsystem - this is for the regulator
driver so it should be regulator:

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)