linux-kernel - Re: [PATCH -next] ASoC: cs42l52: fix the return value of cs42l52_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121107145046.GI20844@opensource.wolfsonmicro.com>
Date:	Wed, 7 Nov 2012 15:50:46 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	lrg@...com, perex@...ex.cz, tiwai@...e.de,
	yongjun_wei@...ndmicro.com.cn, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ASoC: cs42l52: fix the return value of
 cs42l52_set_fmt()

On Wed, Nov 07, 2012 at 08:38:35PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Fix the return value of cs42l52_set_fmt() when clock inversion is
> not allowed and also remove the useless variable ret.

Applied, but you need to work on your changelogs:

What is wrong with the return value?

>  	u8 iface = 0;
>  
>  	switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> @@ -822,7 +821,7 @@ static int cs42l52_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
>  	case SND_SOC_DAIFMT_NB_IF:
>  		break;
>  	default:
> -		ret = -EINVAL;
> +		return -EINVAL;
>  	}
>  	cs42l52->config.format = iface;
>  	snd_soc_write(codec, CS42L52_IFACE_CTL1, cs42l52->config.format);
> 

This doesn't look like it changes the return value...  the actual issue
here is that we don't pay attention to ret later on, we just always
return 0.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)