linux-kernel - RE: [PATCH 6/8] pwm: pwm-tiehrpwm: Adding TBCLK gating support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <518397C60809E147AF5323E0420B992E3E9DE3AA@DBDE01.ent.ti.com>
Date:	Wed, 7 Nov 2012 15:20:30 +0000
From:	"Philip, Avinash" <avinashphilip@...com>
To:	"Bedia, Vaibhav" <vaibhav.bedia@...com>,
	"thierry.reding@...onic-design.de" <thierry.reding@...onic-design.de>,
	"paul@...an.com" <paul@...an.com>,
	"tony@...mide.com" <tony@...mide.com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"Cousson, Benoit" <b-cousson@...com>
CC:	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"Nori, Sekhar" <nsekhar@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Hiremath, Vaibhav" <hvaibhav@...com>,
	"Hebbar, Gururaja" <gururaja.hebbar@...com>,
	"AnilKumar, Chimata" <anilkumar@...com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH 6/8] pwm: pwm-tiehrpwm: Adding TBCLK gating support.

On Tue, Nov 06, 2012 at 12:16:13, Bedia, Vaibhav wrote:
> On Mon, Nov 05, 2012 at 14:42:27, Philip, Avinash wrote:
> [...]
> 
> > +	/* Some platforms require explicit tbclk gating */
> > +	if (of_property_read_bool(pdev->dev.of_node, "tbclkgating")) {
> > +		pc->tbclk = clk_get(&pdev->dev, "tbclk");
> > +		if (IS_ERR(pc->tbclk)) {
> > +			dev_err(&pdev->dev, "Could not get EHRPWM TBCLK\n");
> > +			return PTR_ERR(pc->tbclk);
> > +		}
> > +	}
> > +
> > +	/* Enable tbclk & leave */
> > +	if (pc->tbclk)
> > +		clk_enable(pc->tbclk);
> > +
> 
> Here also why are you leaving this clock always running?

This is an additional clock gating for EHRPWM functional clock from
control module. The enabling of this clock to pwm_enable 
& disabling to pwm_disable. I will correct it.



Thanks
Avinash

> 
> Regards,
> Vaibhav
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/