linux-kernel - Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Nov 2012 00:15:47 +0530 (IST)
From:	Rajanikanth H V <rajanikanth.hv@...aro.org>
To:	Francesco Lavra <francescolavra.fl@...il.com>
cc:	"Rajanikanth H.V" <rajanikanth.hv@...aro.org>,
	rob.herring@...xeda.com, lee.jones@...aro.org, arnd@...db.de,
	anton.vorontsov@...aro.org, linus.walleij@...ricsson.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linaro-dev@...ts.linaro.org, patches@...aro.org,
	STEricsson_nomadik_linux@...t.st.com, rajanikanth.hv@...ricsson.com
Subject: Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

On Thu, 1 Nov 2012, Francesco Lavra wrote:
[...]
>> +	btech = of_get_property(np_bat_supply,
>> +		"stericsson,battery-type", NULL);
>> +	if (!btech) {
>> +		dev_warn(dev, "missing property battery-name/type\n");
>> +		strcpy(bat_tech, "UNKNOWN");
>> +	} else {
>> +		strcpy(bat_tech, btech);
>> +	}
>
> I don't get the point of declaring the char array and copying the string
> in it, when you could simply use just the pointer returned by
> of_get_property().

I am considering a corner case where in 'battery-type' property is not
present and battery is connected.In this case i promote battery to
UNKNOWN from null.
FYI: Further, btemp driver will identify the connected battery based on
resistance value and decide to use.
Ref: ab8500_btemp_id(...) ab8500_btemp.c

> Anyway, if the string property is longer than 8 characters, you are
> writing past the size of the destination array.

i believe it is safe as power_supply.h comprises defines having battery
technology type in 4 characters length which is normally the case and
7 chars length being "UNKNOWN" seldom referred

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/