linux-kernel - Re: [PATCH 0/9] Staging: winbond: Fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 8 Nov 2012 00:22:04 +0530
From:	Adil Mujeeb <mujeeb.adil@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	pavel@....cz
Subject: Re: [PATCH 0/9] Staging: winbond: Fixed coding style issues

Hi,

On Wed, Oct 24, 2012 at 12:15 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Tue, Oct 23, 2012 at 03:41:08PM +0530, Adil Mujeeb wrote:
>> On Tue, Oct 23, 2012 at 2:04 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
>> > On Fri, Oct 12, 2012 at 10:07:06PM +0530, Adil Mujeeb wrote:
>> >>
>> >> winbond directory files have lots of coding style issues. The patch set tries to remove *most* (if not all) of the coding style issues. checkpatch.pl script is still complaining (like 80 characters limit) but major part of the serious coding style issues have been rectified.
>> >
>> > None of your patches can be applied due to the wrong patch level they
>> > were generated at.  Please redo them, drop the two offending patches,
>> > and resend the whole series.
>> >
>> > thanks,
>> >
>> > greg k-h
>>
>> Thanks Greg. I will recreate the patches and shall drop the mentioned
>> ones. But I am still not able find where I am doing wrong in
>> generating the patches. I am following your tutorial :) but may be
>> missing something. Please help. I am doing in the following ways:
>>
>> 1. I am downloading the latest rc source archive from ftp.kernel.org
>> under directory /pub/linux/kernel/v3.x/testing
>> 2. Then creating my own git repository treating the base source as master.
>
> Why not just use the kernel git tree?  You will have to work off of
> linux-next if you want to send staging patches, you can not keep up with
> development otherwise.

Thanks Gree for your suggestion. I am using now linux-next tree.
Interestingly some of my patches already submitted by now :)

>
>> 3. Creating a branch from it and tries to fix some sources.
>> 4. Create the patch through git format-patch
>> 5. Submit the patch through git send-email command.
>>
>> Dry run works fine with my repository. Could you please help?
>
> Your patches could not be applied with "patch -p1" from the root of the
> kernel source tree, I think you created your git repo one directory too
> deep.

Thanks for correcting me. I have realized my mistake. I have submitted
fresh patches.

Thanks,
Adil

>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/