| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <509AEB59.7010504@wwwdotorg.org> Date: Wed, 07 Nov 2012 16:14:33 -0700 From: Stephen Warren <swarren@...dotorg.org> To: Marek Belisko <marek.belisko@...n-nandra.com> CC: cooloney@...il.com, rpurdie@...ys.net, linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org Subject: Re: [PATCH v2 2/2] Add documentation for tca6507 devicetree bindings. On 11/07/2012 01:55 PM, Marek Belisko wrote: > diff --git a/Documentation/devicetree/bindings/leds/tca6507.txt b/Documentation/devicetree/bindings/leds/tca6507.txt > +LEDs conected to tca6507 > + > +Required properties: > +- compatible : should be : "leds-tca6507". "ti,tca6507" would be more typical. > +Each led is represented as a sub-node of the leds-tca6507 device. > + > +LED sub-node properties: > +- label : label for this LED > +- reg : number of LED line (could be from 0 to 6) > +- linux,default-trigger : led default trigger You probably want to mention which binding document defines the valid values for that property; ../gpio/led.txt I think. I wonder if we need to think about representing the blinking/fading/... capabilities of the chip too? Should that be encoded into the DT, or should it be controlled at run-time via some LED subsystem? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists