linux-kernel - Re: [PATCH 077/104] drivers/target/sbp: remove depends on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1352248203.29589.234.camel@haakon2.linux-iscsi.org>
Date:	Tue, 06 Nov 2012 16:30:03 -0800
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Kees Cook <keescook@...omium.org>
Cc:	linux-kernel@...r.kernel.org, Chris Boot <bootc@...tc.net>,
	target-devel <target-devel@...r.kernel.org>
Subject: Re: [PATCH 077/104] drivers/target/sbp: remove depends on
 CONFIG_EXPERIMENTAL

On Mon, 2012-11-05 at 15:04 -0800, Kees Cook wrote:
> The CONFIG_EXPERIMENTAL config item has not carried much meaning for a
> while now and is almost always enabled by default. As agreed during the
> Linux kernel summit, remove it from any "depends on" lines in Kconfigs.
> 
> CC: Chris Boot <bootc@...tc.net>
> CC: "Nicholas A. Bellinger" <nab@...ux-iscsi.org>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  drivers/target/sbp/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/target/sbp/Kconfig b/drivers/target/sbp/Kconfig
> index 132da54..1614bc7 100644
> --- a/drivers/target/sbp/Kconfig
> +++ b/drivers/target/sbp/Kconfig
> @@ -1,6 +1,6 @@
>  config SBP_TARGET
>  	tristate "FireWire SBP-2 fabric module"
> -	depends on FIREWIRE && EXPERIMENTAL
> +	depends on FIREWIRE
>  	help
>  	  Say Y or M here to enable SCSI target functionality over FireWire.
>  	  This enables you to expose SCSI devices to other nodes on the FireWire

Looks fine to drop this usage for sbp-target.

Do you want this patch to be include into the target-pending/for-next ->
for-3.8 branch, or are you planning to take this full series upstream
through a different tree..?

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/