linux-kernel - Re: [PATCH 3/5] gpiolib: remove duplicate pin range code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbZ8VLixWwKOEUMNe+6BJOwCs0Me3=7_oR8xvT9MZx1Aw@mail.gmail.com>
Date:	Thu, 8 Nov 2012 13:54:39 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	viresh kumar <viresh.kumar@...aro.org>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Shiraz Hashim <shiraz.hashim@...com>,
	Stephen Warren <swarren@...dia.com>,
	Anmar Oueja <anmar.oueja@...aro.org>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH 3/5] gpiolib: remove duplicate pin range code

On Wed, Nov 7, 2012 at 6:14 AM, viresh kumar <viresh.kumar@...aro.org> wrote:
> On Tue, Nov 6, 2012 at 8:46 PM, Linus Walleij
> <linus.walleij@...ricsson.com> wrote:
>> From: Linus Walleij <linus.walleij@...aro.org>
>>
>> Commit 69e1601bca88809dc118abd1becb02c15a02ec71
>> "gpiolib: provide provision to register pin ranges"
>>
>> Introduced both of_gpiochip_remove_pin_range() and
>> gpiochip_remove_pin_ranges(). But the contents are exactly
>> the same so remove the OF one and rely on the range deletion
>> in the core.
>>
>> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
>
> I can't believe that i did this :(

Don't worry, it's impossible to get these things right. I am
trying to fix it properly here and just introduce new bugs
for every fix I try to make.

Maybe I'll soon have something that actually doesn't
break x86...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/