linux-kernel - Re: [PATCH 3/5] checkpatch: Remove reference to feature-removal-schedule.txt.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121108174702.GL3066@dm>
Date:	Thu, 8 Nov 2012 17:47:02 +0000
From:	Andy Whitcroft <apw@...onical.com>
To:	Tao Ma <tm@....ma>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 3/5] checkpatch: Remove reference to
 feature-removal-schedule.txt.

On Thu, Nov 08, 2012 at 09:50:33PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@...bao.com>
> 
> In 9c0ece069, Linus removed feature-removal-schedule.txt from Documentation,
> but there is still some reference to this file. So remove them.
> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Andy Whitcroft <apw@...onical.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Tao Ma <boyu.mt@...bao.com>
> ---
>  scripts/checkpatch.pl |   44 --------------------------------------------
>  1 files changed, 0 insertions(+), 44 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 21a9f5d..b0240b8 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -352,27 +352,6 @@ sub deparenthesize {
>  
>  $chk_signoff = 0 if ($file);
>  
> -my @dep_includes = ();
> -my @dep_functions = ();
> -my $removal = "Documentation/feature-removal-schedule.txt";
> -if ($tree && -f "$root/$removal") {
> -	open(my $REMOVE, '<', "$root/$removal") ||
> -				die "$P: $removal: open failed - $!\n";
> -	while (<$REMOVE>) {
> -		if (/^Check:\s+(.*\S)/) {
> -			for my $entry (split(/[, ]+/, $1)) {
> -				if ($entry =~ m@...lude/(.*)@) {
> -					push(@dep_includes, $1);
> -
> -				} elsif ($entry !~ m@/@) {
> -					push(@dep_functions, $entry);
> -				}
> -			}
> -		}
> -	}
> -	close($REMOVE);
> -}
> -
>  my @rawlines = ();
>  my @lines = ();
>  my $vname;
> @@ -3181,29 +3160,6 @@ sub process {
>  			}
>  		}
>  
> -# don't include deprecated include files (uses RAW line)
> -		for my $inc (@dep_includes) {
> -			if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
> -				ERROR("DEPRECATED_INCLUDE",
> -				      "Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
> -			}
> -		}
> -
> -# don't use deprecated functions
> -		for my $func (@dep_functions) {
> -			if ($line =~ /\b$func\b/) {
> -				ERROR("DEPRECATED_FUNCTION",
> -				      "Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
> -			}
> -		}
> -
> -# no volatiles please
> -		my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
> -		if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
> -			WARN("VOLATILE",
> -			     "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
> -		}
> -

This last bit here looks to be an accidental extra deletiong ?  I don't
think this relates to the patch at hand.

>  # warn about #if 0
>  		if ($line =~ /^.\s*\#\s*if\s+0\b/) {
>  			CHK("REDUNDANT_CODE",

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/