linux-kernel - Re: [PATCH 1/8] aoe: avoid running request handler on plugged queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <625E66C0-1433-48B5-84F1-B437DC9DACC9@coraid.com>
Date:	Thu, 8 Nov 2012 13:32:43 -0600
From:	Ed Cashin <ecashin@...aid.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"axboe@...nel.dk" <axboe@...nel.dk>
Subject: Re: [PATCH 1/8] aoe: avoid running request handler on plugged queue

On Nov 8, 2012, at 2:26 PM, Andrew Morton wrote:

> On Thu, 8 Nov 2012 11:29:32 -0500
> Ed Cashin <ecashin@...aid.com> wrote:
> 
>> Signed-off-by: Ed Cashin <ecashin@...aid.com>
> 
> Could you please prepare decent changelogs for the patches?  Several of
> these appear to be bugfixes but we have no description of the
> user-visible behavioural changes.  So nobody knows what the patches do,
> nor which kernel version(s) they should be merged into.

Yes, sure.  For this one, I Cc'ed Jens Axboe in part because although I believe that it is correct to use __blk_run_queue rather than to call the request handler directly, I am going on old information.  I'm not entirely sure what the user impact is when the request hander is called directly, other than perhaps a slight performance hit.

But I'd like to do the right thing.  Jens Axboe, if you have a comment about correctness or user impact, I'd like to include that information in the changelog for this commit.  Or if the change doesn't look right to you, I'd like to know that.

Thanks.

-- 
  Ed Cashin
  ecashin@...aid.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/