[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20121108122001.GC5859@thunk.org>
Date: Thu, 8 Nov 2012 07:20:01 -0500
From: Theodore Ts'o <tytso@....edu>
To: Jarod Wilson <jarod@...hat.com>
Cc: linux-kernel@...r.kernel.org,
Herbert Xu <herbert@...dor.hengli.com.au>,
"David S. Miller" <davem@...emloft.net>,
Neil Horman <nhorman@...driver.com>,
Matt Mackall <mpm@...enic.com>, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v3] random: prime last_data value per fips requirements
On Tue, Nov 06, 2012 at 10:42:42AM -0500, Jarod Wilson wrote:
> The value stored in last_data must be primed for FIPS 140-2 purposes. Upon
> first use, either on system startup or after an RNDCLEARPOOL ioctl, we
> need to take an initial random sample, store it internally in last_data,
> then pass along the value after that to the requester, so that consistency
> checks aren't being run against stale and possibly known data.
>
> v2: streamline code flow a bit, eliminating extra loop and spinlock in the
> case where we need to prime, and account for the extra primer bits.
>
> v3: extract_buf() can't be called with spinlock already held, so bring
> back some extra lock/unlock calls.
>
> CC: Herbert Xu <herbert@...dor.apana.org.au>
> CC: "David S. Miller" <davem@...emloft.net>
> CC: Neil Horman <nhorman@...driver.com>
> CC: Matt Mackall <mpm@...enic.com>
> CC: linux-crypto@...r.kernel.org
> Signed-off-by: Jarod Wilson <jarod@...hat.com>
Thanks, applied to the /dev/random git tree.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists