linux-kernel - Re: [PATCH] fix build waring: drivers/regulator/core.c: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121109110329.GA23807@opensource.wolfsonmicro.com>
Date:	Fri, 9 Nov 2012 11:03:29 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	helight <helight@....com>
Cc:	linux-kernel@...r.kernel.org, lrg@...com
Subject: Re: [PATCH] fix build waring: drivers/regulator/core.c: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized]

On Fri, Nov 09, 2012 at 05:29:40PM +0800, helight wrote:

> -   unsigned int val;
>     int ret;
> +   unsigned int val = 0;

This sort of change is really not at all helpful, we should be making
sure that whatever path should be initialising the value but isn't does
so, just initialising at declaration means that if the compiler has
spotted a genuine error we won't fix it.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)