[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20121109111928.GA2391@avionic-0098.mockup.avionic-design.de>
Date: Fri, 9 Nov 2012 12:19:28 +0100
From: Thierry Reding <thierry.reding@...onic-design.de>
To: "Philip, Avinash" <avinashphilip@...com>
Cc: "paul@...an.com" <paul@...an.com>,
"tony@...mide.com" <tony@...mide.com>,
"linux@....linux.org.uk" <linux@....linux.org.uk>,
"Cousson, Benoit" <b-cousson@...com>,
"Hiremath, Vaibhav" <hvaibhav@...com>,
"AnilKumar, Chimata" <anilkumar@...com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree-discuss@...ts.ozlabs.org"
<devicetree-discuss@...ts.ozlabs.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"Nori, Sekhar" <nsekhar@...com>,
"Hebbar, Gururaja" <gururaja.hebbar@...com>,
"Bedia, Vaibhav" <vaibhav.bedia@...com>,
Rob Herring <rob.herring@...xeda.com>,
Rob Landley <rob@...dley.net>
Subject: Re: [PATCH v2 04/10] pwm: pwm-tiecap: Add device-tree binding
support for APWM driver
On Fri, Nov 09, 2012 at 10:59:30AM +0000, Philip, Avinash wrote:
> On Fri, Nov 09, 2012 at 13:22:19, Thierry Reding wrote:
> > On Thu, Nov 08, 2012 at 01:23:11PM +0530, Philip, Avinash wrote:
> > > +#define ECAPCLK_EN BIT(0)
> > > +#define ECAPCLK_STOP_REQ BIT(1)
> >
> > This one doesn't seem to align with the rest. Also, why is bit 0 called
> > _EN and bit 1 _STOP_REQ? Couldn't they be made more consistent, i.e.
> > _START and _STOP? Or _ENABLE and _DISABLE?
>
> Ok I will change to PWMSS_ECAPCLK_EN & PWMSS_ECAPCLK_STPO_REQ
While at it, maybe move these defines to the pwm-tipwmss.h header file?
After all that's the module that accesses the register that contains
these bits.
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists