linux-kernel - Re: [PATCH] lib/raid6: Add AVX2 optimized recovery functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121109225025.13a846ca@notabene.brown>
Date:	Fri, 9 Nov 2012 22:50:25 +1100
From:	NeilBrown <neilb@...e.de>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Paul Menzel <pm.debian@...glemail.com>,
	Jim Kukunas <james.t.kukunas@...ux.intel.com>,
	Linux Raid <linux-raid@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib/raid6: Add AVX2 optimized recovery functions

On Fri, 09 Nov 2012 12:39:05 +0100 "H. Peter Anvin" <hpa@...or.com> wrote:

> Sorry, we cannot share those at this time since the hardwarenis not yet released.

Can I take that to imply "Acked-by: "H. Peter Anvin" <hpa@...or.com>" ??

It would be nice to have at least a statement like:
 These patches have been tested both with the user-space testing tool and in 
 a RAID6 md array and the pass all test.  While we cannot release performance
 numbers as the hardwere is not released, we can confirm that on that hardware
 the performance with these patches is faster than without.

I guess I should be able to assume that - surely the patches would not be
posted if it were not true...  But I like to avoid assuming when I can.

Thanks,
NeilBrown

> 
> Paul Menzel <pm.debian@...glemail.com> wrote:
> 
> >Dear Jim,
> >
> >
> >Am Donnerstag, den 08.11.2012, 13:47 -0800 schrieb Jim Kukunas:
> >> Optimize RAID6 recovery functions to take advantage of
> >> the 256-bit YMM integer instructions introduced in AVX2.
> >
> >in my experiencing optimizations always have to be back up by
> >benchmarks. Could you add those to the commit message please.
> >
> >> Signed-off-by: Jim Kukunas <james.t.kukunas@...ux.intel.com>
> >
> >[…]
> >
> >
> >Thanks,
> >
> >Paul
> 

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)