[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <426367E2313C2449837CD2DE46E7EAF930E22351@CH1PRD0310MB381.namprd03.prod.outlook.com>
Date: Fri, 9 Nov 2012 15:52:40 +0000
From: KY Srinivasan <kys@...rosoft.com>
To: Tomas Hozza <thozza@...hat.com>, "olaf@...fle.de" <olaf@...fle.de>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
"apw@...onical.com" <apw@...onical.com>,
"jasowang@...hat.com" <jasowang@...hat.com>,
"ben@...adent.org.uk" <ben@...adent.org.uk>
Subject: RE: [PATCH 3/3] tools/hv: Fix permissions of created directory and
files
> -----Original Message-----
> From: Tomas Hozza [mailto:thozza@...hat.com]
> Sent: Friday, November 09, 2012 9:01 AM
> To: olaf@...fle.de; KY Srinivasan; gregkh@...uxfoundation.org; linux-
> kernel@...r.kernel.org; devel@...uxdriverproject.org; apw@...onical.com;
> jasowang@...hat.com; ben@...adent.org.uk
> Cc: Tomas Hozza
> Subject: [PATCH 3/3] tools/hv: Fix permissions of created directory and files
>
> From: Ben Hutchings <ben@...adent.org.uk>
>
> It's silly to create directories without execute permission, or to
> give permissions to 'other' but not the group-owner.
>
> Write the permissions in octal and 'ls -l' format since these are much
> easier to read than the named macros.
>
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> Signed-off-by: Tomas Hozza <thozza@...hat.com>
Acked-by: K. Y. Srinivasan <kys@...rosoft.com>
> ---
> tools/hv/hv_kvp_daemon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index 573b9aa..9609858 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -236,7 +236,7 @@ static int kvp_file_init(void)
> int alloc_unit = sizeof(struct kvp_record) * ENTRIES_PER_BLOCK;
>
> if (access("/var/lib/hyperv", F_OK)) {
> - if (mkdir("/var/lib/hyperv", S_IRUSR | S_IWUSR | S_IROTH)) {
> + if (mkdir("/var/lib/hyperv", 0755 /* rwxr-xr-x */)) {
> syslog(LOG_ERR, " Failed to create /var/lib/hyperv");
> exit(EXIT_FAILURE);
> }
> @@ -247,7 +247,7 @@ static int kvp_file_init(void)
> records_read = 0;
> num_blocks = 1;
> sprintf(fname, "/var/lib/hyperv/.kvp_pool_%d", i);
> - fd = open(fname, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR |
> S_IROTH);
> + fd = open(fname, O_RDWR | O_CREAT, 0644 /* rw-r--r-- */);
>
> if (fd == -1)
> return 1;
> --
> 1.7.11.7
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists