[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <426367E2313C2449837CD2DE46E7EAF930E2236E@CH1PRD0310MB381.namprd03.prod.outlook.com>
Date: Fri, 9 Nov 2012 15:56:58 +0000
From: KY Srinivasan <kys@...rosoft.com>
To: Tomas Hozza <thozza@...hat.com>, "olaf@...fle.de" <olaf@...fle.de>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
"apw@...onical.com" <apw@...onical.com>,
"jasowang@...hat.com" <jasowang@...hat.com>,
"ben@...adent.org.uk" <ben@...adent.org.uk>
Subject: RE: [PATCH 2/3] tools/hv: Fix string types
> -----Original Message-----
> From: Tomas Hozza [mailto:thozza@...hat.com]
> Sent: Friday, November 09, 2012 9:01 AM
> To: olaf@...fle.de; KY Srinivasan; gregkh@...uxfoundation.org; linux-
> kernel@...r.kernel.org; devel@...uxdriverproject.org; apw@...onical.com;
> jasowang@...hat.com; ben@...adent.org.uk
> Cc: Tomas Hozza
> Subject: [PATCH 2/3] tools/hv: Fix string types
>
> Initial patch by Ben Hutchings <ben@...adent.org.uk>
>
> Standard C strings are arrays of char, not __u8 (unsigned char).
> Declare variables and parameters accordingly, and add the necessary
> casts.
>
> Signed-off-by: Tomas Hozza <thozza@...hat.com>
Acked-by: K. Y. Srinivasan <kys@...rosoft.com>
> ---
> tools/hv/hv_kvp_daemon.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index d9b3a74..573b9aa 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -300,7 +300,7 @@ static int kvp_file_init(void)
> return 0;
> }
>
> -static int kvp_key_delete(int pool, __u8 *key, int key_size)
> +static int kvp_key_delete(int pool, const char *key, int key_size)
> {
> int i;
> int j, k;
> @@ -343,7 +343,7 @@ static int kvp_key_delete(int pool, __u8 *key, int
> key_size)
> return 1;
> }
>
> -static int kvp_key_add_or_modify(int pool, __u8 *key, int key_size, __u8
> *value,
> +static int kvp_key_add_or_modify(int pool, const char *key, int key_size, const
> char *value,
> int value_size)
> {
> int i;
> @@ -397,7 +397,7 @@ static int kvp_key_add_or_modify(int pool, __u8 *key, int
> key_size, __u8 *value,
> return 0;
> }
>
> -static int kvp_get_value(int pool, __u8 *key, int key_size, __u8 *value,
> +static int kvp_get_value(int pool, const char *key, int key_size, char *value,
> int value_size)
> {
> int i;
> @@ -429,8 +429,8 @@ static int kvp_get_value(int pool, __u8 *key, int key_size,
> __u8 *value,
> return 1;
> }
>
> -static int kvp_pool_enumerate(int pool, int index, __u8 *key, int key_size,
> - __u8 *value, int value_size)
> +static int kvp_pool_enumerate(int pool, int index, char *key, int key_size,
> + char *value, int value_size)
> {
> struct kvp_record *record;
>
> --
> 1.7.11.7
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists