linux-kernel - Re: [PATCH 2/2] drm: tegra: Add HDMI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <509D28B6.3060207@vodafone.de>
Date:	Fri, 09 Nov 2012 17:00:54 +0100
From:	Christian König <deathsimple@...afone.de>
To:	Rafał Miłecki <zajec5@...il.com>
CC:	Thierry Reding <thierry.reding@...onic-design.de>,
	linux-tegra@...r.kernel.org, Dave Airlie <airlied@...hat.com>,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 2/2] drm: tegra: Add HDMI support

On 09.11.2012 16:45, Rafał Miłecki wrote:
> 2012/11/9 Thierry Reding <thierry.reding@...onic-design.de>:
>> +/* all fields little endian */
>> +struct hdmi_audio_infoframe {
>> +       /* PB0 */
>> +       u8 csum;
>> +
>> +       /* PB1 */
>> +       unsigned cc:3; /* channel count */
>> +       unsigned res1:1;
>> +       unsigned ct:4; /* coding type */
>> +
>> +       /* PB2 */
>> +       unsigned ss:2; /* sample size */
>> +       unsigned sf:3; /* sample frequency */
>> +       unsigned res2:3;
>> +
>> +       /* PB3 */
>> +       unsigned cxt:5; /* coding extention type */
>> +       unsigned res3:3;
>> +
>> +       /* PB4 */
>> +       u8 ca; /* channel/speaker allocation */
>> +
>> +       /* PB5 */
>> +       unsigned res5:3;
>> +       unsigned lsv:4; /* level shift value */
>> +       unsigned dm_inh:1; /* downmix inhibit */
>> +
>> +       /* PB6-10 reserved */
>> +       u8 res6;
>> +       u8 res7;
>> +       u8 res8;
>> +       u8 res9;
>> +       u8 res10;
>> +} __packed;
> I was told it won't work on different endian devices. See
> [RFC][PATCH] drm/radeon/hdmi: define struct for AVI infoframe
> http://lists.freedesktop.org/archives/dri-devel/2012-May/022544.html

Yeah, that's indeed true. And honestly adding just another 
implementation of the HDMI info frames sounds like somebody should 
finally sit down and implement it in a common drm_hdmi.c

Regards,
Christian.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/