linux-kernel - Re: [PATCH] regulator: core: Update regulator_is_supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121109170918.GW23807@opensource.wolfsonmicro.com>
Date:	Fri, 9 Nov 2012 17:09:19 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Tushar Behera <tushar.behera@...aro.org>
Cc:	linux-kernel@...r.kernel.org, philipspatches@...il.com,
	patches@...aro.org
Subject: Re: [PATCH] regulator: core: Update regulator_is_supported_voltage
 for fixed voltages

On Fri, Nov 09, 2012 at 04:21:49PM +0530, Tushar Behera wrote:

> In case of fixed regulators for which voltage cannot be changed,
> regulator_is_supported_voltage should return success only if the
> min_uV and max_uV parameters are same and it is equal to the current
> voltage of the regulator.

This makes no sense to me at all.  The caller is asking if it's possible
to set the voltage between the minimum and maximum values, any voltage
in that range should be OK.  Your patch makes the function massively
less useful.

> Currently this patch breaks MMC support for boards on which vmmc is a
> fixed regulator and the voltage is not equal to either of 3.3v, 3.0v
> or 1.8v. Earlier it used to work if the voltage was less than 3.3v.

This sounds like a problem in the MMC framework.  If it's happy with
non-standard voltages it should be happy with non-standard voltages,
or perhaps it should be ignoring voltages if it can't find any sane
voltages at all.  The regulator framework is accurately answering the
question it was asked.

It also seems like the MMC framework will be broken by a regulator which
can change voltage but not over the full range the MMC framework is
interested in, this is essentially just a special case of that situation.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)