linux-kernel - Re: [PATCH] dmaengine/dmatest: terminate transfers only in case of errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121109195617.GB25358@jonmason-lab>
Date:	Fri, 9 Nov 2012 12:56:18 -0700
From:	Jon Mason <jon.mason@...el.com>
To:	Dan Williams <djbw@...com>
Cc:	Viresh Kumar <viresh.kumar@...aro.org>,
	"vinod.koul@...el.com" <vinod.koul@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"spear-devel@...t.st.com" <spear-devel@...t.st.com>,
	Shiraz Hashim <shiraz.hashim@...com>,
	Deepak Sikri <deepak.sikri@...com>,
	"dave.jiang@...el.com" <dave.jiang@...el.com>
Subject: Re: [PATCH] dmaengine/dmatest: terminate transfers only in case of
 errors

On Fri, Nov 09, 2012 at 06:44:18PM +0000, Dan Williams wrote:
> 
> 
> On 11/9/12 7:26 AM, "Viresh Kumar" <viresh.kumar@...aro.org> wrote:
> 
> >From: Shiraz Hashim <shiraz.hashim@...com>
> >
> >dmatest erroneously terminated transfers in normal cases also leading to
> >test failures for multiple threads over a channel. Fix this and
> >terminate transfers only in case of errors.
> >
> >Signed-off-by: Shiraz Hashim <shiraz.hashim@...com>
> >Signed-off-by: Deepak Sikri <deepak.sikri@...com>
> >---
> > drivers/dma/dmatest.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> >diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> >index 8f130d4e..ce58b8e 100644
> >--- a/drivers/dma/dmatest.c
> >+++ b/drivers/dma/dmatest.c
> >@@ -509,7 +509,9 @@ err_srcs:
> > 			thread_name, total_tests, failed_tests, ret);
> > 
> > 	/* terminate all transfers on specified channels */
> >-	chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
> >+	if (ret)
> >+		chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
> >+
> 
> This and commit 9704efa "dmaengine/dmatest: Terminate transfers on all
> channels in case of error or exit" are broken for channels that don't
> implement the optional ->device_control.  Care to fix that up?

I think the best way is to call dmaengine_terminate_all() and have a
sanity check in dmaengine_device_control() that checks for a NULL
device_control.  I have a patch that does this and fixes the NULL
pointer error I am seeing on IOAT.  I will send it out shortly.

Thanks,
Jon

> 
> 
> --
> Dan
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/