linux-kernel - Re: [PATCH] fuse: remove unused variable in fuse_try_move

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87haoxa1p6.fsf@tucsk.pomaz.szeredi.hu>
Date:	Sat, 10 Nov 2012 16:59:33 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	yongjun_wei@...ndmicro.com.cn, fuse-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fuse: remove unused variable in fuse_try_move_page()

Wei Yongjun <weiyj.lk@...il.com> writes:

> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> The variables mapping,index are initialized but never used
> otherwise, so remove the unused variables.
>
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)

Thanks, applied.

Miklos

>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  fs/fuse/dev.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
> index 8c23fa7..53c294c 100644
> --- a/fs/fuse/dev.c
> +++ b/fs/fuse/dev.c
> @@ -692,8 +692,6 @@ static int fuse_try_move_page(struct fuse_copy_state *cs, struct page **pagep)
>  	struct page *oldpage = *pagep;
>  	struct page *newpage;
>  	struct pipe_buffer *buf = cs->pipebufs;
> -	struct address_space *mapping;
> -	pgoff_t index;
>  
>  	unlock_request(cs->fc, cs->req);
>  	fuse_copy_finish(cs);
> @@ -724,9 +722,6 @@ static int fuse_try_move_page(struct fuse_copy_state *cs, struct page **pagep)
>  	if (fuse_check_page(newpage) != 0)
>  		goto out_fallback_unlock;
>  
> -	mapping = oldpage->mapping;
> -	index = oldpage->index;
> -
>  	/*
>  	 * This is a new and locked page, it shouldn't be mapped or
>  	 * have any special flags on it
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/