linux-kernel - Re: [PATCH] spi: tegra: sequence compatible strings as per preference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121110170741.GA17689@avionic-0098.mockup.avionic-design.de>
Date:	Sat, 10 Nov 2012 18:07:42 +0100
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"spi-devel-general@...ts.sourceforge.net" 
	<spi-devel-general@...ts.sourceforge.net>,
	Laxman Dewangan <ldewangan@...dia.com>,
	Stephen Warren <swarren@...dia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <rob.herring@...xeda.com>
Subject: Re: [PATCH] spi: tegra: sequence compatible strings as per preference

On Fri, Nov 09, 2012 at 10:28:38AM -0700, Stephen Warren wrote:
> On 11/09/2012 10:10 AM, Mark Brown wrote:
> > On Fri, Nov 09, 2012 at 10:04:56AM -0700, Stephen Warren wrote:
> > 
> >> However just FYI, it should not be necessary for correctness; The
> >> DT matching order is supposed to be driven purely by the order of
> >> the compatible values in the DT now, and not affected by the
> >> order of values in the table. (This wasn't always the case, but
> >> was a bug that was fixed IIRC by Thierry Reding).
> > 
> > I guess the driver is being used backported in older kernels which
> > don't have that fix?
> 
> That sounds likely. Laxman, it'd be a good idea to track down the fix
> to the DT matching code and backport it, so that hard-to debug issues
> aren't caused by the lack of that patch!

Unfortunately the patch that was supposed to fixed this caused a
regression and was therefore reverted. Rob (Cc'ed) said there was a
patch to fix it properly and was supposed to go into 3.6 but it seems
that never happened. Rob, what's the status on this?

The revert is here: bc51b0c22cebf5c311a6f1895fcca9f78efd0478

Thierry

Content of type "application/pgp-signature" skipped