lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20121111124310.GA4313@local>
Date:	Sun, 11 Nov 2012 13:43:10 +0100
From:	"Hans J. Koch" <hjk@...sjkoch.de>
To:	Manuel Traut <manut@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, "Hans J. Koch" <hjk@...sjkoch.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Stefan Staedtler <stefan.staedtler@...mens.com>,
	Magnus Damm <magnus.damm@...il.com>,
	Uwe Kleine-Koenig <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH] uio_pdrv: set memory mapping name

On Fri, Nov 09, 2012 at 07:06:40AM +0100, Manuel Traut wrote:
> If uio_pdrv[_genirq] is used, the uio maps have currently no name set.
> This patch sets the uio_mem name to the name of the memory resource.

Looks fine to me. I added the driver's authors to Cc.

Signed-off-by: "Hans J. Koch" <hjk@...sjkoch.de>

>  
> Signed-off-by: Manuel Traut <manut@...utronix.de>
> Reported-by: Stefan Staedtler <stefan.staedtler@...mens.com>
> Tested-by: Stefan Staedtler <stefan.staedtler@...mens.com>
> 
> diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
> index 42202cd..ac988ce 100644
> --- a/drivers/uio/uio_pdrv_genirq.c
> +++ b/drivers/uio/uio_pdrv_genirq.c
> @@ -172,6 +172,7 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
>  		uiomem->memtype = UIO_MEM_PHYS;
>  		uiomem->addr = r->start;
>  		uiomem->size = resource_size(r);
> +		uiomem->name = r->name;
>  		++uiomem;
>  	}
>  
> diff --git a/drivers/uio/uio_pdrv.c b/drivers/uio/uio_pdrv.c
> index 72d3646..39be9e0 100644
> --- a/drivers/uio/uio_pdrv.c
> +++ b/drivers/uio/uio_pdrv.c
> @@ -60,6 +60,7 @@ static int uio_pdrv_probe(struct platform_device *pdev)
>  		uiomem->memtype = UIO_MEM_PHYS;
>  		uiomem->addr = r->start;
>  		uiomem->size = resource_size(r);
> +		uiomem->name = r->name;
>  		++uiomem;
>  	}
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ